Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear reloadable flag for workspace modules that happen to be dependencies of non-reloadable dependencies #26411

Merged
merged 1 commit into from Jun 30, 2022
Merged

Clear reloadable flag for workspace modules that happen to be dependencies of non-reloadable dependencies #26411

merged 1 commit into from Jun 30, 2022

Conversation

aloubyansky
Copy link
Member

@aloubyansky aloubyansky commented Jun 28, 2022 •
edited

Fix #24895

This change makes sure that local project dependencies are not flagged as reloadable if they happen to be dependencies (direct or transitive) of non-reloadable dependencies.

@quarkus-bot quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 28, 2022
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@aloubyansky
Copy link
Member Author

@gsmet @geoand I know it's hard to follow these changes, I'd like to get this in ASAP though to get this tested more before the next release.

geoand
geoand approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it in!

@aloubyansky aloubyansky merged commit 7789684 into quarkusio:main Jun 30, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jun 30, 2022
@bcluap bcluap mentioned this pull request Jun 30, 2022
Closed
@michalvavrik michalvavrik mentioned this pull request Jul 1, 2022
Closed
@aloubyansky aloubyansky mentioned this pull request Jul 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform kind/bugfix
Projects
None yet
Milestone
2.11.0.CR1
Development

Successfully merging this pull request may close these issues.

Classloader Issues on MultiModule Project Tests
2 participants
@aloubyansky @geoand