Use uppercase UP in ReactiveDatasourceHealthCheck

[luckyguy73]

request to change the data default value to uppercase to match the status case. the status enum in HealthCheckResponse is uppercase, so this would make them both the same case for consistency, which is good for those of us with OCD and looks good when getting values from json from q/health or viewing webpage at q/health-ui 😀

[gsmet]

Let's not merge this right away.

The behavior is completely different from the one in the Agroal extension: https://github.com/quarkusio/quarkus/blob/main/extensions/agroal/runtime/src/main/java/io/quarkus/agroal/runtime/health/DataSourceHealthCheck.java and it would probably be better to have a consistent behavior.

But we need decide which is better :).

/cc @yrodiere @tsegismont

[yrodiere]

@gsmet I'm not sure how this is usually done, but in any case it seems to make sense to give details about each datasource, even those that are up. So I'd be inclined to do the same with Agroal?

[gsmet]

@yrodiere OK. Last question is if we should refer to the default datasource as default or <default> for the health checks. Given they are used programmatically, I would lean towards the latter but open to discussion.

[yrodiere]

OK. Last question is if we should refer to the default datasource as default or <default>

+1 for <default>, that's more consistent with configuration, logs, etc. And it will avoid problems when someone decides to name their datasource default (no </>)...

I created a ticket: #26431

[gsmet]

OK, then this one is all good. Let's merge it.

[gsmet]

Thanks!