Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump proto-google-common-protos from 2.0.1 to 2.9.1 #26440

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 29, 2022

Bumps proto-google-common-protos from 2.0.1 to 2.9.1.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [proto-google-common-protos](https://github.com/googleapis/java-iam) from 2.0.1 to 2.9.1.
- [Release notes](https://github.com/googleapis/java-iam/releases)
- [Changelog](https://github.com/googleapis/java-iam/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/java-iam/commits)

---
updated-dependencies:
- dependency-name: com.google.api.grpc:proto-google-common-protos
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the area/dependencies Pull requests that update a dependency file label Jun 29, 2022
@gsmet gsmet requested a review from loicmathieu June 29, 2022 13:07
@gsmet
Copy link
Member

gsmet commented Jun 29, 2022

@ppalaga could you have a look at this one?

Because of:
https://github.com/quarkusio/quarkus/pull/26069/commits that introduced a constraint with a very old version
and the discussion in quarkusio/quarkus-platform#569 (review)

Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 🤞

@quarkus-bot

This comment has been minimized.

@loicmathieu
Copy link
Contributor

Can someone have a look at why it failed ? Maybe @ppalaga or @cescoffier as it seems to cause issue on gRPC and SMRM tests.

It would be greate to have this for 2.10.2 as it currently prevent the usage of Quarkus 2.10 with any Google Cloud services extensions.

@cescoffier
Copy link
Member

Hum, do be honest, I'm not totally sure that the failures come from the PR. That being said, it's rare to get so many.

@quarkus-bot

This comment has been minimized.

@loicmathieu
Copy link
Contributor

loicmathieu commented Jul 1, 2022

@cescoffier I tested locally integration-tests/grpc-hibernate with the updated dependency and it works, so this PR may be safe to merge.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 1, 2022

Failing Jobs - Building 6fd7255

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs
Maven Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/elasticsearch-rest-client 

📦 integration-tests/elasticsearch-rest-client

Failed to execute goal io.fabric8:docker-maven-plugin:0.40.1:start (docker-start) on project quarkus-integration-test-elasticsearch-rest-client: I/O Error


⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven 

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testCapabilitiesConflict line 108 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.maven.it.DevMojoIT.testCapabilitiesConflict line 108 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@cescoffier cescoffier merged commit d43f4ea into main Jul 2, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jul 2, 2022
@dependabot dependabot bot deleted the dependabot/maven/com.google.api.grpc-proto-google-common-protos-2.9.1 branch July 2, 2022 10:04
@gsmet gsmet modified the milestones: 2.11 - main, 2.10.2.Final Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file kind/component-upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants