Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Hibernate Reactive to 1.1.7.Final #26482

Merged
merged 1 commit into from Jul 1, 2022

Conversation

DavideD
Copy link
Contributor

@DavideD DavideD commented Jun 30, 2022

Latest Hibernate Reactive release

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 30, 2022
@gsmet
Copy link
Member

gsmet commented Jun 30, 2022

@DavideD is it something we should backport to 2.10?

@DavideD
Copy link
Contributor Author

DavideD commented Jun 30, 2022

I think so. We fixed a pretty nasty bug: hibernate/hibernate-reactive#975

@gsmet
Copy link
Member

gsmet commented Jun 30, 2022

OK thanks. Label added.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 30, 2022

Failing Jobs - Building 9e153c8

Status Name Step Failures Logs Raw logs
MicroProfile TCKs Tests Verify Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ MicroProfile TCKs Tests #

- Failing: tcks/resteasy-reactive 

📦 tcks/resteasy-reactive

Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:exec (test) on project quarkus-tck-resteasy-reactive: Command execution failed.

📦 tcks/resteasy-reactive/target/testsuite/tests

com.sun.ts.tests.jaxrs.spec.filter.interceptor.JAXRSClient0021.readerWriterContainerInterceptorTest line 453 - More details - Source on GitHub

java.lang.AssertionError: [WebValidatorBase] Unexpected Status Code recieved from server.  Expected '200' received '500'
	at com.sun.ts.tests.jaxrs.spec.filter.interceptor.JAXRSClient0021.readerWriterContainerInterceptorTest(JAXRSClient0021.java:453)

@geoand
Copy link
Contributor

geoand commented Jul 1, 2022

The failing test has nothing to do with this PR, it's being addressed in #26492

@geoand geoand merged commit 0a890dc into quarkusio:main Jul 1, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jul 1, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 1, 2022
@Sanne
Copy link
Member

Sanne commented Jul 1, 2022

We'll need this backported to 2.7 as well

@fedinskiy
Copy link
Contributor

@gsmet it looks like this change was not backported to 2.7: https://github.com/quarkusio/quarkus/blob/2.7/bom/application/pom.xml#L95

@gsmet
Copy link
Member

gsmet commented Feb 21, 2023

Hmmm. I think we tried to upgrade it and then we stumbled upon some issues with either Mutiny or Vert.x and had to back off.

It should be removed from the 2.7 version. I will adjust the PR.

@gsmet gsmet modified the milestones: 2.7.7.Final, 2.10.2.Final Feb 21, 2023
@gsmet
Copy link
Member

gsmet commented Feb 21, 2023

I had a recollection of having written something about it and it's here: #30367 (comment) .

But we forgot to unmark the pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants