Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stork guide minor improvements and cross linking #26508

Merged
merged 1 commit into from Jul 1, 2022

Conversation

loicmathieu
Copy link
Contributor

Some minor enhancement to the Stork guide and cross linking.

The title and introduction section of the Stork with Kubernetes was the same as the Getting Started one which is disturbing.

I also think the title of the Stork guide on the guide page should be updated to "Getting Started with Stock" or even better "Service discovery and Load Balancing with Stork" but I don't remember where to modify the title.
image

@gsmet
Copy link
Member

gsmet commented Jul 1, 2022

The title for the website should be changed here: https://github.com/quarkusio/quarkusio.github.io/blob/develop/_data/guides-latest.yaml (and also in the guides-main.yaml).

@loicmathieu
Copy link
Contributor Author

@gsmet now that you say it, I remember it ;)
I'll send a PR, which title should be best ?
"Getting Started with Stock" or "Service discovery and Load Balancing with Stork"

@gsmet
Copy link
Member

gsmet commented Jul 1, 2022

I will let @cescoffier choose :).

@cescoffier
Copy link
Member

I would go with "Service discovery and Load Balancing with Stork". It's longer but more explicit for people that never heard about Stork (and I met a few...).

@gsmet gsmet merged commit ae7fff4 into quarkusio:main Jul 1, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jul 1, 2022
@gsmet gsmet modified the milestones: 2.11 - main, 2.10.2.Final Jul 4, 2022
@loicmathieu loicmathieu deleted the stork-guide-title branch July 8, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants