Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Redis cursors to consume items individually #26578

Merged
merged 1 commit into from Jul 7, 2022

Conversation

cescoffier
Copy link
Member

The Redis commands return batches, but the developers usually want to iterate over the items individually.
This commit adds the methods to iterate (using a Multi or an Iterable) over the items.

Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good to me.

Spotted a couple usage of wildcard imports which I think needs to be removed.

…dually and not by batches

The Redis commands return batches, but the developers usually want to iterate over the items individually.
This commit adds the methods to iterate (using a Multi or an Iterable) over the items.
@cescoffier cescoffier force-pushed the redis-scan-items-individually branch from d4584c3 to 3dafae0 Compare July 7, 2022 05:51
@gsmet gsmet merged commit c95c4a0 into quarkusio:main Jul 7, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jul 7, 2022
@cescoffier cescoffier deleted the redis-scan-items-individually branch July 7, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants