RESTEasy Reactive - Perform eager security checks for JaxRS security #26579
+58
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sberyozkin
approved these changes
Jul 6, 2022
This comment has been minimized.
This comment has been minimized.
michalvavrik
force-pushed
the
feature/fix-jaxrs-deny-unannotated-endpoints-nonblocking
branch
from
8b3aff0
to
69ac7cd
Compare
michalvavrik
deleted the
feature/fix-jaxrs-deny-unannotated-endpoints-nonblocking
branch
|
I'm not very comfortable backporting this to 2.10 as it relies on some other PR and put together the changes are rather involved and touch security. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #26553
Same issue as with #23547, security checks with disabled proactive security on the IO thread performed by
SecurityConstrainerleads to an exception as identity is accessed in a synchronous manner. Now these checks are performed eagerly in RR so by the time checks are performed bySecurityConstrainer, user is already authenticated - same situation as with RBAC annotations.