Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Instant.EPOCH when adding docker layers #26758

Merged
merged 1 commit into from Jul 19, 2022
Merged

Conversation

fbotis
Copy link
Contributor

@fbotis fbotis commented Jul 15, 2022

Use Instant.EPOCH when adding docker layers so if the content of the files do not change the layer digest doesn't change either

fixes: 26734

@fbotis
Copy link
Contributor Author

fbotis commented Jul 15, 2022

@geoand just created a new PR with the squashed commits

@geoand
Copy link
Contributor

geoand commented Jul 15, 2022

Thanks, I'll take a closer look on Monday

Use Instant.EPOCH when adding docker layers so if the content of the files do not change the layer digest doesn't change either
@gsmet
Copy link
Member

gsmet commented Jul 18, 2022

I rebased to trigger CI, which was somehow not triggered.

@geoand
Copy link
Contributor

geoand commented Jul 19, 2022

I'll review next week when I'm back (hopefully)

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gastaldi mind taking a quick look at this as well?

Thanks

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nitpick

@gastaldi gastaldi merged commit 25911d6 into quarkusio:main Jul 19, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Jul 19, 2022
@gastaldi
Copy link
Contributor

gastaldi commented Jul 19, 2022

Thanks for your contribution @fbotis 🎉 !

@fbotis
Copy link
Contributor Author

fbotis commented Jul 19, 2022

Happy to help! Looking forward creating the next PR :)

@fbotis fbotis deleted the 26734-fix branch July 19, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIB Extension and docker layers
4 participants