Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add limitations for Basic Authentication #26817

Merged
merged 1 commit into from Jul 20, 2022
Merged

Docs: Add limitations for Basic Authentication #26817

merged 1 commit into from Jul 20, 2022

Conversation

hmanwani-rh
Copy link
Contributor

See JIRA: https://issues.redhat.com/browse/QDOCS-29

Added limitations for Basic Authentication in "security-built-in-authentication.adoc" file.

Doc preview: http://file.pnq.redhat.com/~hmanwani/QDOCS-29-main

@sberyozkin
Copy link
Member

Hi @hmanwani-rh Nice work, I've added a few minor suggestions which I thought could clarify a few details better, have a look please

@MichalMaler MichalMaler self-requested a review July 19, 2022 18:21
@hmanwani-rh
Copy link
Contributor Author

hmanwani-rh commented Jul 20, 2022 •
edited

Hi @hmanwani-rh Nice work, I've added a few minor suggestions which I thought could clarify a few details better, have a look please

@sberyozkin Thanks for reviewing the update and sharing the comments. I've incorporated the changes as suggested.
Please take a look one more time and let me know if we're good to merge this PR.

@MichalMaler
Copy link
Contributor

Hi @hmanwani-rh Nice work, I've added a few minor suggestions which I thought could clarify a few details better, have a look please

@sberyozkin Thanks for reviewing the update and sharing the comments. I've incorporated the changes as suggested.

Good Job @hmanwani-rh . Will add my review now. Will add just few lines to make it complete.

@MichalMaler
Copy link
Contributor

LGTM

@MichalMaler MichalMaler added the good first issue Good for newcomers label Jul 20, 2022
@sberyozkin
Copy link
Member

Thanks @hmanwani-rh I've just squashed a few last commits with Minor fix messages...

@MichalMaler
Copy link
Contributor

I think they will need to have it all in a single commit only. @hmanwani-rh

@sberyozkin
Copy link
Member

@MichalMaler I kept the last 2 ones as I did not want a reference to your contribution be lost :-), I will squash now to the single commit as looks like you are OK with it :-)

@sberyozkin
Copy link
Member

@hmanwani-rh @MichalMaler All is ready now, thanks for your contribution :-)

@MichalMaler
Copy link
Contributor

@MichalMaler I kept the last 2 ones as I did not want a reference to your contribution be lost :-), I will squash now to the single commit as looks like you are OK with it :-)

Oh well, hope it will be written forever in our hearts :D :D Thank you for the attitude thought! Well done, We!

@sberyozkin sberyozkin merged commit e049f41 into quarkusio:main Jul 20, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sberyozkin sberyozkin sberyozkin approved these changes

@MichalMaler MichalMaler MichalMaler approved these changes

Assignees
No one assigned
Labels
area/documentation good first issue Good for newcomers
Projects
None yet
Milestone
2.12.0.CR1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hmanwani-rh @sberyozkin @MichalMaler