Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the quarkus-kotlin extension status to stable #26846

Merged
merged 1 commit into from Jul 25, 2022

Conversation

aloubyansky
Copy link
Member

Following the discussion https://groups.google.com/g/quarkus-dev/c/Yz3BriSfsf4/m/HVFLNfPtCAAJ?utm_medium=email&utm_source=footer

It doesn't seem like there are major issues to fix to earn the stable status for quarkus-kotlin. Any objections?

gsmet
gsmet previously requested changes Jul 20, 2022
@@ -5,7 +5,6 @@ https://github.com/quarkusio/quarkus/tree/main/docs/src/main/asciidoc
////
= Using Kotlin

:extension-status: preview
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove include::{includes}/extension-status.adoc[] a few lines below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsmet I see you asked the same in #26709. There is a nice message when the extension status is stable, what's the reason behind removing it?

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gastaldi we always only included the note in non-stable extensions so I want us to stay consistent.

Copy link
Member

@glefloch glefloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenyee
Copy link

kenyee commented Jul 20, 2022

Also would be nice to have someplace where there's docs for the caveats mentioned in the the dev thread for Kotlin support.
e.g. panache-reactive module doesn't support Kotlin, Kotlin coroutines aren't supported everywhere, etc.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@evanchooly
Copy link
Member

we should probably also "promote" the other kotlin modules.

  • mongodb-panache-kotlin is listed as stable already
  • hibernate-orm-panache-kotlin is still experimental.
  • quarkus-resteasy-reactive-kotlin doesn't have anything in it's quarkus-extension.yaml at all. I don't know what that means.
  • resteasy-reactive-kotlin-serialization is listed as experimental

Copy link
Member

@evanchooly evanchooly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably also "promote" the other kotlin modules.

  • mongodb-panache-kotlin is listed as stable already
  • hibernate-orm-panache-kotlin is still experimental.
  • quarkus-resteasy-reactive-kotlin doesn't have anything in it's quarkus-extension.yaml at all. I don't know what that means.
  • resteasy-reactive-kotlin-serialization is listed as experimental

@aloubyansky
Copy link
Member Author

we should probably also "promote" the other kotlin modules.

  • mongodb-panache-kotlin is listed as stable already
  • hibernate-orm-panache-kotlin is still experimental.
  • quarkus-resteasy-reactive-kotlin doesn't have anything in it's quarkus-extension.yaml at all. I don't know what that means.
  • resteasy-reactive-kotlin-serialization is listed as experimental

Just to clarify, @evanchooly you would like to make them all stable?

quarkus-resteasy-reactive-kotlin is unlisted which means it's not exposed to users for explicit selection. It's activated automagically when both quarkus-resteasy-reactive and quarkus-kotlin are found among the project's dependencies.

@aloubyansky
Copy link
Member Author

Changed the statuses of hibernate-orm-panache-kotlin and resteasy-reactive-kotlin-serialization to stable. I left quarkus-resteasy-reactive-kotlin as-is, given that we aren't currently displaying unlisted extensions to users and if a status is missing, I guess we could assume it's stable, although we may want to discuss that.

@gsmet
Copy link
Member

gsmet commented Jul 21, 2022

@n1hility I think you should probably be involved in this discussion too.

@n1hility
Copy link
Member

@evanchooly do you expect any major changes to the extensions in this list? I just want to make sure that we are at a stage where we feel good about the APIs and they are not under flux.

@evanchooly
Copy link
Member

I don't. All the panache bits are driven by common interfaces and the others don't have much or any user facing interfaces.

@n1hility
Copy link
Member

Ok then I am +1 sans any extensions we have doubts about.

@gsmet gsmet dismissed their stale review July 25, 2022 12:29

Addressed.

@gsmet
Copy link
Member

gsmet commented Jul 25, 2022

@evanchooly I let you have a look to the latest changes and merge if ready.

@ebullient ebullient added this to Review pending in Quarkus Documentation Jul 25, 2022
Quarkus Documentation automation moved this from Review pending to Reviewer approved Jul 25, 2022
@gsmet gsmet merged commit 1a3841b into quarkusio:main Jul 25, 2022
Quarkus Documentation automation moved this from Reviewer approved to Done Jul 25, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

7 participants