Add deprecated to extension status note
#26899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
changed the title
deprecated to extension status note
Also fix the Extension status URL
gsmet
approved these changes
Jul 23, 2022
Christopher-Chianelli
added a commit
to Christopher-Chianelli/quarkus
that referenced
this pull request
Jul 25, 2022
When both get getters and is getters exist, they can replace the original selected getter in PropertyUtils. This can creates inconsistencies, resulting in a field not being set, causing a NPE later down the line that is hard to diagnose. To remove inconsistencies, if there is both a get method and an is method, the get method is always preferred. This introduces consistent behavior for recorders. To accomplish this, a seperate map is used for isGetters in PropertyUtils. Using a seperate map removes the need to have a seperate loop for identifing the actual getter method. It also make the logic more clear (first try "get" getter, then try "is" getter).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix the Extension status URL