Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to GraalVM 22.2.0 #26943

Merged
merged 2 commits into from Aug 4, 2022
Merged

Bump to GraalVM 22.2.0 #26943

merged 2 commits into from Aug 4, 2022

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Jul 26, 2022 •
edited

Requires quarkusio/quarkus-images#201 to be merged first

@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Jul 26, 2022
@gastaldi gastaldi requested review from zakkak and gsmet July 26, 2022 17:46
@gastaldi gastaldi marked this pull request as draft July 26, 2022 17:51
@gastaldi gastaldi added env/graalvm-java11 Relating to using GraalVM native image generation on Java 11 env/graalvm-java17 Relating to using GraalVM native generation Java 11 labels Jul 26, 2022
gsmet
gsmet requested changes Jul 26, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of the changes are missing. See https://github.com/quarkusio/quarkus/pull/25366/files for reference.

@quarkus-bot

This comment has been minimized.

Sign in to view
zakkak
zakkak previously requested changes Jul 27, 2022
View reviewed changes
core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java Outdated Show resolved Hide resolved
core/deployment/src/main/java/io/quarkus/deployment/steps/NativeImageFeatureStep.java Outdated Show resolved Hide resolved
core/deployment/src/main/java/io/quarkus/deployment/steps/NativeImageFeatureStep.java Outdated Show resolved Hide resolved
core/deployment/src/main/java/io/quarkus/deployment/steps/NativeImageFeatureStep.java Outdated Show resolved Hide resolved
core/deployment/src/main/java/io/quarkus/deployment/steps/NativeImageFeatureStep.java Outdated Show resolved Hide resolved
core/deployment/src/main/java/io/quarkus/deployment/steps/NativeImageFeatureStep.java Outdated Show resolved Hide resolved
core/deployment/src/main/java/io/quarkus/deployment/steps/NativeImageFeatureStep.java Outdated Show resolved Hide resolved
core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/GraalVM.java Show resolved Hide resolved
@gastaldi gastaldi requested review from gsmet and zakkak July 27, 2022 13:37
@gastaldi gastaldi marked this pull request as ready for review July 27, 2022 13:37
@gastaldi gastaldi marked this pull request as draft July 27, 2022 13:37
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@gastaldi gastaldi marked this pull request as ready for review July 29, 2022 13:23
@gastaldi gastaldi marked this pull request as draft July 29, 2022 13:34
@gastaldi
Copy link
Contributor Author

Marking as a draft until the build in https://github.com/quarkusio/quarkus-images is fixed

@gastaldi gastaldi marked this pull request as ready for review August 3, 2022 12:24
@quarkus-bot

This comment has been minimized.

Sign in to view
@gastaldi
Copy link
Contributor Author

gastaldi commented Aug 3, 2022

Yay! Green CI 🎆 🎉 🎉 🎉

gsmet
gsmet approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but let's wait for @zakkak before merging.

@gastaldi
Copy link
Contributor Author

gastaldi commented Aug 4, 2022

@gsmet Since @zakkak is away all of august and @galderz approved it, maybe we can merge this?

@gsmet gsmet merged commit a657c83 into quarkusio:main Aug 4, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Aug 4, 2022
@gastaldi gastaldi deleted the graalvm_22_2 branch August 4, 2022 13:34
gastaldi added a commit to gastaldi/quarkus that referenced this pull request Aug 4, 2022
@gastaldi
Add URL and Description for Feature classes
ed00504 
Follow up on quarkusio#26943
gastaldi added a commit to gastaldi/quarkus that referenced this pull request Aug 4, 2022
@gastaldi
Add URL and Description for Feature classes
176b810 
Follow up on quarkusio#26943
@gastaldi gastaldi mentioned this pull request Aug 4, 2022
Merged
gastaldi added a commit to gastaldi/quarkus that referenced this pull request Aug 5, 2022
@gastaldi
Add Description for Feature classes
08a6401 
Follow up on quarkusio#26943
miador pushed a commit to miador/quarkus that referenced this pull request Sep 6, 2022
@gastaldi @miador
Add Description for Feature classes
9d8e1e4 
Follow up on quarkusio#26943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galderz galderz galderz approved these changes

@gsmet gsmet gsmet approved these changes

@zakkak zakkak Awaiting requested review from zakkak

Assignees
No one assigned
Labels
area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/native-image env/graalvm-java11 Relating to using GraalVM native image generation on Java 11 env/graalvm-java17 Relating to using GraalVM native generation Java 11
Projects
None yet
Milestone
2.12.0.CR1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gastaldi @galderz @gsmet @zakkak