Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Liquibase to 4.14.0 and resolve most deprecation warnings #26977

Merged
merged 1 commit into from Jul 29, 2022
Merged

Update Liquibase to 4.14.0 and resolve most deprecation warnings #26977

merged 1 commit into from Jul 29, 2022

Conversation

famod
Copy link
Member

@famod famod commented Jul 27, 2022

WIP for now because the mongo part is not done yet, which I'd do if we agree that my changes are ok.
I'll also squash everything, eventually.

On main thing to keep in mind with this is the following item from the changelog:

so I removed the "pro" stuff.

I'll also leave some review comments...

@famod famod requested a review from geoand July 27, 2022 23:10
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/liquibase labels Jul 27, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 27, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

.collect(Collectors.toSet());

resource.produce(
new NativeImageResourceBuildItem(getChangeLogs(dataSourceNames, liquibaseBuildConfig).toArray(new String[0])));

Stream.of(liquibase.change.Change.class,
liquibase.changelog.ChangeLogHistoryService.class,
liquibase.command.LiquibaseCommand.class,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is deprecated, hence also this change: https://github.com/quarkusio/quarkus/pull/26977/files#diff-930f0d68c059b4088f05d8c3d7a725e110279966c77958a6d699f9c652bde81eL48-R47

It was added back in #9636, but I don't see how the following is still the case today:

This capability is also shown in our Liquibase quickstart

@geoand
Copy link
Contributor

geoand commented Jul 28, 2022

Seems reasonable

@famod
Copy link
Member Author

famod commented Jul 28, 2022

Any input from your side @gsmet @loicmathieu? If not I'll go ahead and finish this.

@loicmathieu
Copy link
Contributor

@famod nothing to say, go ahead ;)

@famod famod changed the title [WIP] Update Liquibase to 4.14.0 Update Liquibase to 4.14.0 and resolve most deprecation warnings Jul 28, 2022
@famod
Copy link
Member Author

famod commented Jul 28, 2022

Mongo stuff added, ready for final review!

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 29, 2022

Failing Jobs - Building 863fa43

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs
✔️ Gradle Tests - JDK 11 Windows
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 18 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.CompositeBuildWithDependenciesDevModeTest.main line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ JVM Tests - JDK 18 #

- Failing: integration-tests/container-image/maven-invoker-way 

📦 integration-tests/container-image/maven-invoker-way

Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.2.2:run (integration-tests) on project quarkus-integration-test-container-image-invoker: 1 build failed. See console output above for details.

@famod famod merged commit 354b536 into quarkusio:main Jul 29, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Jul 29, 2022
@famod famod deleted the liquibase-4.14.0 branch July 29, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/documentation area/liquibase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants