Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ValidatorFactory and Validator singleton beans #27001

Merged
merged 1 commit into from Jul 29, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jul 28, 2022

Created as draft to get CI feedback and because I will wait for #26997 to get in.

@quarkus-bot quarkus-bot bot added the area/hibernate-validator Hibernate Validator label Jul 28, 2022
@manovotn
Copy link
Contributor

@gsmet I'll just add these changes as a separate commit into #26997 :)

@gsmet
Copy link
Member Author

gsmet commented Jul 28, 2022

@manovotn ah sorry, I just saw your message, I merged it as CI was green and I'm not completely sure this one will go in :). I'll adjust the small things in there.

@manovotn
Copy link
Contributor

@manovotn ah sorry, I just saw your message, I merged it as CI was green and I'm not completely sure this one will go in :). I'll adjust the small things in there.

Hehe, good timing; I was literally just pushing these changes into the PR. Doesn't matter though.

I think this change makes sense as I didn't come across any piece of code that would use Validator and somehow required that it should be dependent. If you have any further CDI questions, fire away :)

@gsmet gsmet force-pushed the validatorfactory-singleton branch from 155658e to f2f909b Compare July 28, 2022 13:47
@gsmet gsmet marked this pull request as ready for review July 28, 2022 22:00
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 28, 2022

Failing Jobs - Building f2f909b

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs
✔️ Gradle Tests - JDK 11 Windows

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.CompositeBuildWithDependenciesDevModeTest.main line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@gsmet gsmet requested a review from manovotn July 29, 2022 07:45
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I don't think it is worth a backport, but I'll leave that up to you.

@gsmet gsmet merged commit f19dd4c into quarkusio:main Jul 29, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Jul 29, 2022
@gsmet gsmet modified the milestones: 2.12 - main, 2.11.2.Final Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-validator Hibernate Validator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants