Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate HibernateValidatorFactoryCustomizer in favor of ValidatorFactoryCustomizer #27004

Merged
merged 2 commits into from Aug 1, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jul 28, 2022

And document it.
While working on the documentation, I realized that we are referencing
ValidatorFactory everywhere so it makes no sense to call the customizer
with the Hibernate prefix.

For now, I deprecated the interface, it will be dropped in the next minor version
as it was only in one micro and the usage is relatively narrow.

@quarkus-bot

This comment has been minimized.

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the deprecation would be better handled with simply inheritance, and I'm not sure the renaming is legitimate (see comments below).

Let's just discuss it. If you disagree with me, I'll approve anyway; it's your extension after all :)

…ctoryCustomizer

And document it.
While working on the documentation, I realized that we are referencing
ValidatorFactory everywhere so it makes no sense to call the customizer
with the Hibernate prefix.

For now, I deprecated the class, it will be dropped in the next minor version
as it was only in one micro and the usage is relatively narrow.
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 29, 2022

Failing Jobs - Building 71ee592

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs
✔️ Gradle Tests - JDK 11 Windows

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.CompositeBuildWithDependenciesDevModeTest.main line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@yrodiere yrodiere merged commit db8116e into quarkusio:main Aug 1, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Aug 1, 2022
@gsmet gsmet modified the milestones: 2.12 - main, 2.11.2.Final Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants