Introduce a new set of test callbacks used right before and after test execution

[geoand]

These callbacks essentially offer similar functionality to JUnit's
org.junit.jupiter.api.extension.BeforeTestExecutionCallback and
org.junit.jupiter.api.extension.AfterTestExecutionCallback

Closes: #26999

[Cs4r]

Thanks for your work @geoand.

However, how can I build a jar with these changes? 😅

[geoand]

You can do the following:

git clone -b #26999 --single-branch git@github.com:geoand/quarkus.git
cd quarkus
mvn -Dquickly -Dformat.skip=true

Then use the following BOM:

      <dependency>
        <groupId>io.quarkus</groupId>
        <artifactId>quarkus-bom</artifactId>
        <version>999-SNAPSHOT</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>

[Cs4r]

@geoand:

if I do a git clone -b #26999 --single-branch git@github.com:geoand/quarkus.git I get the error:

error: switch `b' requires a value

If I do a git clone -b 26999 --single-branch git@github.com:geoand/quarkus.git (without hash) I get the error:

Cloning into 'quarkus'...
warning: Could not find remote branch 26999 to clone.
fatal: Remote branch 26999 not found in upstream origin

Thanks in advance.

[geoand]

Can you try git clone -b '#26999' --single-branch git@github.com:geoand/quarkus.git?

[Cs4r]

@geoand :

Apparently, this feature doesn't work yet.

I have created a simple class implementing io.quarkus.test.junit.callback.QuarkusTestBeforeTestCallback:

package cs4r;

import io.quarkus.test.junit.callback.QuarkusTestBeforeTestCallback;
import io.quarkus.test.junit.callback.QuarkusTestMethodContext;

public class MyQuarkusTestBeforeTestCallback implements QuarkusTestBeforeTestCallback {

    @Override
    public void beforeTest(QuarkusTestMethodContext context) {
        System.out.println("beforeTest");
    }
}

Then (as https://quarkus.io/guides/getting-started-testing#enrichment-via-quarkustestcallback says) I have created the file src/main/resources/META-INF/services/io.quarkus.test.junit.callback.QuarkusTestBeforeTestCallback with the following content:

cs4r.MyQuarkusTestBeforeTestCallback

but for some reason I am not aware of yet, the callback is never executed.

This is also happening with io.quarkus.test.junit.callback.QuarkusTestAfterTestCallback, therefore I reckon it might be that the algorithm for parsing the files:

• src/main/resources/META-INF/services/io.quarkus.test.junit.callback.QuarkusTestBeforeTestCallback
• src/main/resources/META-INF/services/io.quarkus.test.junit.callback.QuarkusTestAfterTestCallback

is missing.

[geoand]

Can you share the example project you used?

[geoand]

PR updated, it should work now (I force pushed to the branch, so best delete your local copy of it)

[Cs4r]

@geoand this time it works like a charm 😄

Will this be added in the next release?

Thanks in advance.

[geoand]

Thanks a lot for checking!

It will be included in 2.12.0.CR1 onwards, but I am wondering if we can add it to 2.11.2.Final - WDYT @gsmet?

[geoand]

I'll finish the PR tomorrow by adding tests

[gastaldi]

Small naming suggestion change to match the same hooks JUnit provides

[geoand]

Good point! Fixed

[gastaldi]

Missing doc changes, but the rest looks okay, approved ;)

[geoand]

I knew I would miss something :)

[gsmet]

Will backport it to the next 2.11 micro.

[geoand]

Great, thanks!