Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump avro.version from 1.11.0 to 1.11.1 #27070

Merged
merged 2 commits into from Aug 18, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 1, 2022

Bumps avro.version from 1.11.0 to 1.11.1.
Updates avro from 1.11.0 to 1.11.1

Updates avro-compiler from 1.11.0 to 1.11.1

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `avro.version` from 1.11.0 to 1.11.1.

Updates `avro` from 1.11.0 to 1.11.1

Updates `avro-compiler` from 1.11.0 to 1.11.1

---
updated-dependencies:
- dependency-name: org.apache.avro:avro
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.avro:avro-compiler
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the area/dependencies Pull requests that update a dependency file label Aug 1, 2022
@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Aug 2, 2022

@ozangunalp apparently, this upgrade breaks the Kafka Avro tests. Could you have a look?

@ozangunalp
Copy link
Contributor

@gsmet I finally re-wrote the substitution for the class GenericDatumReader from Avro to match the latest version.
But If we remove the substitution altogether the native compiler no longer complains about the thread usage, both of our ITs pass and the behavior seems to be the same.

@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Aug 9, 2022

@ozangunalp I think the failures are related as the errors are of the form:

Caused by: com.oracle.graal.pointsto.constraints.UnsupportedFeatureException: Detected a started Thread in the image heap. Threads running in the image generator are no longer running at image runtime. To see how this object got instantiated use --trace-object-instantiation=java.lang.Thread. The object was probably created by a class initializer and is reachable from a static field. You can request class initialization at image runtime by using the option --initialize-at-run-time=. Or you can write your own initialization methods and call them explicitly from your main entry point.

So I don't know exactly which class but my guess is that it's the one for which you removed the substitution.

@ozangunalp
Copy link
Contributor

That's odd, I didn't expected that infinispan failure was related. Without the substitution the avro related native compilations passed. I'll push the fixed substitution rather than removing it.

@ozangunalp ozangunalp force-pushed the dependabot/maven/avro.version-1.11.1 branch from 8ec3a91 to 4d2032e Compare August 10, 2022 04:05
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 10, 2022

Failing Jobs - Building 4d2032e

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs
✔️ Gradle Tests - JDK 11 Windows

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.CompositeBuildWithDependenciesDevModeTest.main line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@gsmet
Copy link
Member

gsmet commented Aug 10, 2022

CI is definitely happier.

@gsmet gsmet merged commit 0767824 into main Aug 18, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Aug 18, 2022
@dependabot dependabot bot deleted the dependabot/maven/avro.version-1.11.1 branch August 18, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file kind/component-upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants