Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs metadata generation #27233

Merged
merged 1 commit into from Aug 15, 2022
Merged

Conversation

ebullient
Copy link
Contributor

  • Summary: Use the first sentence of the preamble or the 'summary' attribute value.
  • Use a 'categories' attribute for gross category grouping, including 'get-started' for "Getting Started" / introductory tutorials.

- Summary: Use the first sentence of the preamble or the 'summary' attribute value.
- Use a 'categories' attribute for gross category grouping, including 'get-started' for "Getting Started" / introductory tutorials.
@michelle-purcell
Copy link
Contributor

@ebullient - Looks good 👍

What if both the 'summary' attribute and the asciidoc 'preamble' exist? Which takes precedence and gets added to the "summary:" (formerly "description") bit of the index.yml file, as per the screencap below? Apologies if I missed this in the code. Thanks :-)

image

@ebullient
Copy link
Contributor Author

What if both the 'summary' attribute and the asciidoc 'preamble' exist? Which takes precedence and gets added to the "summary:" (formerly "description") bit of the index.yml file, as per the screencap below? Apologies if I missed this in the code. Thanks :-)

The summary wins.

String result = (summary != null ? summary.toString() : content.orElse(""))

@maxandersen
Copy link
Contributor

looks fine - is the output of this hooked into the publishing yet or is that a TDB?

@michelle-purcell
Copy link
Contributor

@ebullient - FYI and related to this PR:
As per our discussion last week, I started to add some guidance in PR27286 about how to write a 'good' abstract and how it (will) dynamically generate the one-liner for the home page.

Also...

Ideally, the first-sentence summary of the abstract (aka asciidoc preamble) should be less than 26 words. Would it make sense to add a validation check? Thanks.

@ebullient
Copy link
Contributor Author

looks fine - is the output of this hooked into the publishing yet or is that a TDB?

Not hooked into publishing yet. All of this is still in-flight / under review. The lastest changes are after reviewing with Michelle, which gave me some ideas for making the intent of some fields easier to understand.

Copy link
Contributor

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Quarkus Documentation automation moved this from To do to Reviewer approved Aug 15, 2022
@ebullient ebullient merged commit 3b822b2 into quarkusio:main Aug 15, 2022
Quarkus Documentation automation moved this from Reviewer approved to Done Aug 15, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Aug 15, 2022
@ebullient ebullient deleted the docs-summary branch August 16, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants