Custom OIDC claim verification #27292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sberyozkin
reviewed
Aug 16, 2022
extensions/oidc/runtime/src/main/java/io/quarkus/oidc/OidcTenantConfig.java
Outdated
Show resolved
Hide resolved
sberyozkin
reviewed
Aug 16, 2022
extensions/oidc/runtime/src/main/java/io/quarkus/oidc/OidcTenantConfig.java
Outdated
Show resolved
Hide resolved
|
@djnalluri LGTM, thanks, I've added a couple of minor suggestions. Please also squash the commits. Note your PR also indirectly fixes #17292. now there is no need to add a dedicated property for |
djnalluri
force-pushed
the
feature/oidc-custom-claim-verification
branch
from
49d86c5
to
eeb7291
Compare
This comment has been minimized.
This comment has been minimized.
Co-authored-by: sberyozkin <sberyozkin@gmail.com>
djnalluri
force-pushed
the
feature/oidc-custom-claim-verification
branch
from
eeb7291
to
a7b9c2e
Compare
sberyozkin
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new configuration property for specifying claims that should be present and matching in an OIDC token.
Fixes #27138.
Also Fixes #17292.