Exclude com.microsoft.azure:msal4j from the application BOM #27359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beyond us not actually needing this dependency, it was also transitively pulling in a dependency on com.nimbusds:oauth2-oidc-sdk which in turns enables additional Maven repositories on the project. We really don't want that to happen.
quarkus-bot
bot
added
the
area/dependencies
|
Flagging for backport as well, as it's fixing an issue introduced by #24010 |
aloubyansky
approved these changes
Aug 18, 2022
gastaldi
added
the
triage/waiting-for-ci
Failing Jobs - Building c3f2aaf
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: integration-tests/opentelemetry-vertx
📦 integration-tests/opentelemetry-vertx✖ |
quarkus-bot
bot
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27358
Beyond us not actually needing this dependency, it was also transitively pulling in a dependency on com.nimbusds:oauth2-oidc-sdk which in turns enables additional Maven repositories on the project.
We really don't want that to happen: people might not trust it, it slows the build, and complicates project builds when they need offline/proxy definitions for each repository.