Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OTel to 1.17.0 #27363

Merged
merged 1 commit into from Aug 24, 2022
Merged

Upgrade OTel to 1.17.0 #27363

merged 1 commit into from Aug 24, 2022

Conversation

brunobat
Copy link
Contributor

@brunobat brunobat commented Aug 18, 2022

Support deprecated and new moved WithSpan …and SpanAttribute annotations
Still missing:

  • opentelemetry-alpha instrumentation release.
  • Issue with annotation transformations

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/tracing labels Aug 18, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 18, 2022

/cc @radcortez

gsmet
gsmet previously requested changes Aug 18, 2022
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that's why you created it as draft but let's make it clear.

bom/application/pom.xml Outdated Show resolved Hide resolved
@quarkus-bot

This comment has been minimized.

@Ladicek
Copy link
Contributor

Ladicek commented Aug 23, 2022

Just one correction and one tiny suggestion, otherwise looks good.

Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brunobat I am fine with the PR now, just one quesiton. There is one TODO in the code as well as several commented out parts in tests; is this something that should be resolved as part of this PR or are we tracking it elsewhere?

@brunobat
Copy link
Contributor Author

brunobat commented Aug 23, 2022

@brunobat I am fine with the PR now, just one question. There is one TODO in the code as well as several commented out parts in tests; is this something that should be resolved as part of this PR or are we tracking it elsewhere?

I can create an issue on our side to update them...
First, I created this on OTel, because it's a bug on their side: open-telemetry/opentelemetry-java#4715
@manovotn Created this one for us: #27441

…and SpanAttribute annotations

Semantic convention updates net.peer.addr->net.sock.peer.addr
@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 24, 2022

Failing Jobs - Building 5877676

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: devtools/cli devtools/gradle/gradle-model 
! Skipped: devtools/gradle/gradle-application-plugin devtools/gradle/gradle-extension-plugin 

📦 devtools/cli

io.quarkus.cli.CliProjectGradleTest.testExtensionList line 214 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {

io.quarkus.cli.CliProjectGradleTest.testCreateAppDefaults line 117 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {

io.quarkus.cli.CliProjectGradleTest.testCreateAppDefaultsWithKotlinDSL line 142 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {

io.quarkus.cli.CliProjectGradleTest.testCreateCliDefaults line 201 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {

io.quarkus.cli.CliProjectGradleTest.testCreateAppOverrides line 179 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {

📦 devtools/gradle/gradle-model

Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:exec (gradle) on project quarkus-gradle-model: Command execution failed.

@gsmet gsmet dismissed their stale review August 24, 2022 19:33

Addressed.

@gsmet gsmet merged commit c51233e into quarkusio:main Aug 24, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants