New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade OTel to 1.17.0 #27363
Upgrade OTel to 1.17.0 #27363
Conversation
/cc @radcortez |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose that's why you created it as draft but let's make it clear.
02eb753
to
db363da
Compare
db363da
to
10e8bee
Compare
...try/deployment/src/main/java/io/quarkus/opentelemetry/deployment/OpenTelemetryProcessor.java
Outdated
Show resolved
Hide resolved
...try/deployment/src/main/java/io/quarkus/opentelemetry/deployment/OpenTelemetryProcessor.java
Outdated
Show resolved
Hide resolved
...try/deployment/src/main/java/io/quarkus/opentelemetry/deployment/OpenTelemetryProcessor.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
...try/deployment/src/main/java/io/quarkus/opentelemetry/deployment/OpenTelemetryProcessor.java
Outdated
Show resolved
Hide resolved
...try/deployment/src/main/java/io/quarkus/opentelemetry/deployment/OpenTelemetryProcessor.java
Outdated
Show resolved
Hide resolved
.../runtime/src/main/java/io/quarkus/opentelemetry/runtime/tracing/cdi/WithSpanInterceptor.java
Outdated
Show resolved
Hide resolved
.../runtime/src/main/java/io/quarkus/opentelemetry/runtime/tracing/cdi/WithSpanInterceptor.java
Outdated
Show resolved
Hide resolved
...try/deployment/src/main/java/io/quarkus/opentelemetry/deployment/OpenTelemetryProcessor.java
Outdated
Show resolved
Hide resolved
10e8bee
to
02dfab1
Compare
...try/deployment/src/main/java/io/quarkus/opentelemetry/deployment/OpenTelemetryProcessor.java
Outdated
Show resolved
Hide resolved
.../runtime/src/main/java/io/quarkus/opentelemetry/runtime/tracing/cdi/WithSpanInterceptor.java
Outdated
Show resolved
Hide resolved
Just one correction and one tiny suggestion, otherwise looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brunobat I am fine with the PR now, just one quesiton. There is one TODO
in the code as well as several commented out parts in tests; is this something that should be resolved as part of this PR or are we tracking it elsewhere?
I can create an issue on our side to update them... |
…and SpanAttribute annotations Semantic convention updates net.peer.addr->net.sock.peer.addr
961ff93
to
5877676
Compare
This comment has been minimized.
This comment has been minimized.
Failing Jobs - Building 5877676
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: devtools/cli devtools/gradle/gradle-model
! Skipped: devtools/gradle/gradle-application-plugin devtools/gradle/gradle-extension-plugin 📦 devtools/cli✖
✖
✖
✖
✖
📦 devtools/gradle/gradle-model✖ |
Support deprecated and new moved WithSpan …and SpanAttribute annotations
Still missing: