Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take HTTP root path into account when using @TestHTTPResource #27419

Merged
merged 3 commits into from Aug 23, 2022
Merged

Take HTTP root path into account when using @TestHTTPResource #27419

merged 3 commits into from Aug 23, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Aug 22, 2022

Fixes: #27416

@geoand geoand requested a review from gastaldi August 22, 2022 12:02
gastaldi
gastaldi approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@gastaldi
Copy link
Contributor

Worth mentioning this in the migration docs, as it may break users doing #27416 (comment)

@geoand
Copy link
Contributor Author

geoand commented Aug 22, 2022

Good point

@geoand geoand mentioned this pull request Aug 22, 2022
Closed
@geoand
Copy link
Contributor Author

geoand commented Aug 22, 2022

@gastaldi you might want to take another quick look since I added 2 more super simple commits

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 22, 2022
@quarkus-bot

This comment has been minimized.

Sign in to view
@gastaldi
Copy link
Contributor

Looks like this change broke some tests 🤔

@geoand
Copy link
Contributor Author

geoand commented Aug 23, 2022

Test failures were legit but they should be addressed now

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 23, 2022

Failing Jobs - Building 78f418d

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/opentelemetry-vertx

📦 integration-tests/opentelemetry-vertx

✖ io.quarkus.it.opentelemetry.vertx.HelloRouterTest.bus line 134 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <CONSUMER> but was: <PRODUCER>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

@geoand geoand merged commit cacd153 into quarkusio:main Aug 23, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Aug 23, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Aug 23, 2022
@geoand geoand deleted the #27416 branch August 23, 2022 09:59
@geoand geoand mentioned this pull request Sep 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/metrics area/testing area/websockets kind/bugfix release/breaking-change
Projects
None yet
Milestone
2.13.0.CR1
Development

Successfully merging this pull request may close these issues.

@TestHTTPResource annotation injects endpoint URL without the quarkus.http.root-path segment
2 participants
@geoand @gastaldi