Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for DOCKER_CONFIG env var when using Jib #27471

Merged
merged 1 commit into from Aug 24, 2022
Merged

Add support for DOCKER_CONFIG env var when using Jib #27471

merged 1 commit into from Aug 24, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Aug 24, 2022

Resolves: #27460

@geoand geoand requested a review from gastaldi August 24, 2022 06:10
gastaldi
gastaldi approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a small suggestion, as according to the Paths javadoc:

It is recommended to obtain a Path via the Path.of methods instead of via the get methods defined in this class as this class may be deprecated in a future release

@geoand @gastaldi
Add support for DOCKER_CONFIG env var when using Jib
8b042db 
Resolves: quarkusio#27460

Co-authored-by: George Gastaldi <gegastaldi@gmail.com>
@geoand
Copy link
Contributor Author

geoand commented Aug 24, 2022

Good point!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 24, 2022
@gsmet gsmet merged commit f4eac7a into quarkusio:main Aug 24, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Aug 24, 2022
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Aug 24, 2022
@geoand geoand deleted the #27460 branch August 25, 2022 03:50
@gsmet gsmet modified the milestones: 2.13 - main, 2.12.1.Final Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/container-image kind/enhancement New feature or request
Projects
None yet
Milestone
2.12.1.Final
Development

Successfully merging this pull request may close these issues.

Honour DOCKER_CONFIG location for jib credentials
3 participants
@geoand @gastaldi @gsmet