Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegisterForReflection#classNames does not register full hierarchy of the class #27551

Merged
merged 1 commit into from Oct 20, 2022

Conversation

igorregis
Copy link
Contributor

@igorregis igorregis commented Aug 28, 2022

fix #21985
PR originally being discussed here (RegisterForReflection#classNames does not register full hierarchy of the class), original was mistakenly closed by me.

@igorregis
Copy link
Contributor Author

Thanks for the orientation @zakkak, the rebase indeed did the trick.

@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Aug 29, 2022

Can you please rebase onto main?

@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Sep 13, 2022

We'll need another rebase-squash please

@zakkak
Copy link
Contributor

zakkak commented Sep 15, 2022

@igorregis it looks like this will need to be squashed in a single commit well before going in, right now the PR includes 39 commits most of which are merging main.

@igorregis
Copy link
Contributor Author

@igorregis it looks like this will need to be squashed in a single commit well before going in, right now the PR includes 39 commits most of which are merging main.

Yep, have never done this before, so I'm on the learning process :-) Sorry for that.

@igorregis igorregis force-pushed the RegisterForReflection branch 4 times, most recently from 3d8cdcd to 94b5a3e Compare September 18, 2022 21:43
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@igorregis igorregis force-pushed the RegisterForReflection branch 2 times, most recently from b0acd17 to 7300e9b Compare October 16, 2022 22:54
@igorregis igorregis force-pushed the RegisterForReflection branch 5 times, most recently from 625682d to 8036380 Compare October 16, 2022 23:53
@igorregis igorregis force-pushed the RegisterForReflection branch 2 times, most recently from c5759e2 to 8036380 Compare October 17, 2022 00:00
@quarkus-bot quarkus-bot bot added area/codestarts area/elasticsearch area/hibernate-validator Hibernate Validator area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search / Elasticsearch area/jackson Issues related to Jackson (JSON library) area/kotlin labels Oct 17, 2022
@igorregis igorregis force-pushed the RegisterForReflection branch 4 times, most recently from d5d4ab9 to 8036380 Compare October 17, 2022 00:19
@quarkus-bot

This comment has been minimized.

@zakkak
Copy link
Contributor

zakkak commented Oct 17, 2022

@radcortez could you please have a look at this. It looks good to me but I would like a second pair of eyes on it :)

@radcortez
Copy link
Member

Sure!

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 20, 2022

Failing Jobs - Building 9594945

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/vertx/deployment 
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 340 more

📦 extensions/vertx/deployment

io.quarkus.vertx.DuplicatedContextTest.testThatBlockingEventConsumersAreCalledOnDuplicatedContext - More details - Source on GitHub

(RECIPIENT_FAILURE,8185) io.smallrye.mutiny.TimeoutException
	at io.vertx.core.eventbus.Message.fail(Message.java:141)
	at io.quarkus.vertx.runtime.VertxRecorder$3$1$1.handle(VertxRecorder.java:122)

⚙️ JVM Tests - JDK 17 MacOS M1 #

- Failing: integration-tests/mongodb-devservices 

📦 integration-tests/mongodb-devservices

io.quarkus.it.mongodb.BookResourceTest.health line 45 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:283)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:309)

io.quarkus.it.mongodb.BookResourceTest.testReactiveClients line 39 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:283)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:309)

io.quarkus.it.mongodb.BookResourceTest.testBlockingClient line 34 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:283)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:309)

io.quarkus.it.mongodb.BookResourceWithParameterInjectionTest.testInjectedClient line 31 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:283)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:309)

io.quarkus.it.mongodb.OtherProfileBookResourceTest.testBlockingClient line 14 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:283)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:309)

@zakkak zakkak merged commit afd9164 into quarkusio:main Oct 20, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 20, 2022
@igorregis igorregis deleted the RegisterForReflection branch October 22, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RegisterForReflection#classNames does not register full hierarchy of the class
4 participants