New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RegisterForReflection#classNames does not register full hierarchy of the class #27551
Conversation
Thanks for the orientation @zakkak, the rebase indeed did the trick. |
This comment has been minimized.
This comment has been minimized.
Can you please rebase onto |
This comment has been minimized.
This comment has been minimized.
We'll need another rebase-squash please |
@igorregis it looks like this will need to be squashed in a single commit well before going in, right now the PR includes 39 commits most of which are merging |
Yep, have never done this before, so I'm on the learning process :-) Sorry for that. |
3d8cdcd
to
94b5a3e
Compare
94b5a3e
to
f5b98cf
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
b0acd17
to
7300e9b
Compare
625682d
to
8036380
Compare
c5759e2
to
8036380
Compare
d5d4ab9
to
8036380
Compare
This comment has been minimized.
This comment has been minimized.
@radcortez could you please have a look at this. It looks good to me but I would like a second pair of eyes on it :) |
Sure! |
8036380
to
9594945
Compare
Failing Jobs - Building 9594945
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/vertx/deployment
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 340 more 📦 extensions/vertx/deployment✖
⚙️ JVM Tests - JDK 17 MacOS M1 #- Failing: integration-tests/mongodb-devservices
📦 integration-tests/mongodb-devservices✖
✖
✖
✖
✖
|
fix #21985
PR originally being discussed here (RegisterForReflection#classNames does not register full hierarchy of the class), original was mistakenly closed by me.