Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky ClientRequestTest #27599

Merged
merged 1 commit into from Sep 8, 2022
Merged

Fix flaky ClientRequestTest #27599

merged 1 commit into from Sep 8, 2022

Conversation

brunobat
Copy link
Contributor

fixes #27578

@quarkus-bot

This comment has been minimized.

Sign in to view
@brunobat brunobat force-pushed the fix-client-request-test branch 2 times, most recently from 066f53c to 84f9fb9 Compare August 31, 2022 08:48
@quarkus-bot

This comment has been minimized.

Sign in to view
@gsmet
Copy link
Member

gsmet commented Aug 31, 2022

The good news is that it's not flaky anymore :].

@quarkus-bot

This comment has been minimized.

Sign in to view
@brunobat brunobat force-pushed the fix-client-request-test branch 2 times, most recently from 8c0e98c to ffbbebf Compare September 2, 2022 10:27
@quarkus-bot

This comment has been minimized.

Sign in to view
@brunobat
Copy link
Contributor Author

brunobat commented Sep 2, 2022

Yeah... will have to create a specific endpoint on the service to get the test data.

@quarkus-bot

This comment has been minimized.

Sign in to view
@gsmet
Copy link
Member

gsmet commented Sep 5, 2022

@brunobat please be a bit more conservative with our CI resources:

  • make sure your stuff compiles and is well formatted before pushing (at least)
  • please don't push any merge commits because we will ask you to rebase anyway to get rid of it before we can merge

Thanks!

@brunobat
Fix flaky ClientRequestTest.
a511c4f 
Use awaitility
Don't use injection on this test.
Get test data from inside the process
@geoand
Copy link
Contributor

geoand commented Sep 8, 2022

So is this ready to go?

@gsmet gsmet merged commit 8018aaa into quarkusio:main Sep 8, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@ebullient ebullient ebullient approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.13.0.CR1
Development

Successfully merging this pull request may close these issues.

Fix flaky ClientRequestTest
4 participants
@brunobat @gsmet @geoand @ebullient