Bring JBossNettyLoggerFactory implementation in line with other implementations #27653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mentations This change essentially makes all the method implementations behave in the same way Netty's built-in implementations do. Fixes: quarkusio#27605 Co-authored-by: David M. Lloyd <david.lloyd@redhat.com>
dmlloyd
approved these changes
Sep 1, 2022
| log.error(msg, t); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| // MessageFormatter class copied from Netty because its methods are package private |
There was a problem hiding this comment.
😩 Can we also put in an enhancement request upstream to Netty to make these public? Otherwise it defeats the purpose of having the logger be pluggable after all.
There was a problem hiding this comment.
Yup: netty/netty#12761
There was a problem hiding this comment.
Once netty/netty#12763 is in and we have new Netty version (looks like 4.1.81) in Quarkus that makes the methods public, we can delete the copied code
There was a problem hiding this comment.
#28126 now removes the copied code
geoand
added a commit
to geoand/quarkus
that referenced
this pull request
Sep 21, 2022
MessageFormatter and FormattingTuple were originally copied from Netty because they didn't have the proper access modifiers for us to use them. With Netty 4.1.81 now being used in Quarkus, we can now use the actual classes so let's get rid of the redundancy. Follows up on: quarkusio#27653, quarkusio#28077
geoand
added a commit
to geoand/quarkus
that referenced
this pull request
Sep 21, 2022
MessageFormatter and FormattingTuple were originally copied from Netty because they didn't have the proper access modifiers for us to use them. With Netty 4.1.81 now being used in Quarkus, we can now use the actual classes so let's get rid of the redundancy. Follows up on: quarkusio#27653, quarkusio#28077
igorregis
pushed a commit
to igorregis/quarkus
that referenced
this pull request
Oct 16, 2022
MessageFormatter and FormattingTuple were originally copied from Netty because they didn't have the proper access modifiers for us to use them. With Netty 4.1.81 now being used in Quarkus, we can now use the actual classes so let's get rid of the redundancy. Follows up on: quarkusio#27653, quarkusio#28077
igorregis
pushed a commit
to igorregis/quarkus
that referenced
this pull request
Oct 16, 2022
MessageFormatter and FormattingTuple were originally copied from Netty because they didn't have the proper access modifiers for us to use them. With Netty 4.1.81 now being used in Quarkus, we can now use the actual classes so let's get rid of the redundancy. Follows up on: quarkusio#27653, quarkusio#28077
igorregis
pushed a commit
to igorregis/quarkus
that referenced
this pull request
Oct 16, 2022
MessageFormatter and FormattingTuple were originally copied from Netty because they didn't have the proper access modifiers for us to use them. With Netty 4.1.81 now being used in Quarkus, we can now use the actual classes so let's get rid of the redundancy. Follows up on: quarkusio#27653, quarkusio#28077
igorregis
pushed a commit
to igorregis/quarkus
that referenced
this pull request
Oct 17, 2022
MessageFormatter and FormattingTuple were originally copied from Netty because they didn't have the proper access modifiers for us to use them. With Netty 4.1.81 now being used in Quarkus, we can now use the actual classes so let's get rid of the redundancy. Follows up on: quarkusio#27653, quarkusio#28077
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change essentially makes all the method implementations behave in the same
way Netty's built-in implementations do.
Fixes: #27605