-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework the BeanDefiningAnnotationBuildItem default scope #27658
Conversation
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/Beans.java
Outdated
Show resolved
Hide resolved
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/Beans.java
Outdated
Show resolved
Hide resolved
- it was previously implemented as a "synthetic" stereotype; the downsides of this solution were (1) there was a need to distinguish "real" and "bda" stereotypes so that the bda one can be ignored if a real stereotype with a default scope is used (otherwise users might get unexpected definition errors) and (2) it was not possible to define CDI qualifier as a bean defining annotation with a default scope
05ffef6
to
8322420
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Failing Jobs - Building 8322420
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/smallrye-reactive-messaging-amqp/deployment
! Skipped: integration-tests/reactive-messaging-amqp 📦 extensions/smallrye-reactive-messaging-amqp/deployment✖
✖
✖
✖
✖
|
I'm going to merge this PR. The windows CI failure does not seem to be related. |
downsides of this solution were (1) there was a need to distinguish
"real" and "bda" stereotypes so that the bda one can be ignored if a
real stereotype with a default scope is used (otherwise users might get
unexpected definition errors) and (2) it was not possible to define CDI
qualifier as a bean defining annotation with a default scope