Support empty env var values in Kubernetes/Knative/OpenShift extensions #27681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sgitario
changed the title
geoand
reviewed
Sep 2, 2022
...bernetes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/EnvVarHolder.java
Outdated
Show resolved
Hide resolved
Sgitario
force-pushed
the
kubernetes_allow_envvar_optional
branch
from
7505ed6
to
002af34
Compare
geoand
approved these changes
Sep 2, 2022
geoand
added
the
triage/waiting-for-ci
quarkus-bot
bot
added
kind/bugfix
and removed
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows setting env var with empty values:
quarkus.kubernetes.env.vars.TESTVAR=Fix #27663