Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global rest-client config properties #27715

Merged
merged 1 commit into from Sep 5, 2022

Conversation

TomasHofman
Copy link
Contributor

Resolves #27635

This commit adds global properties for most of configuration options
that can be set to individual REST client instances. E.g. the scope
property, that previously could only be set for specific client with:

quarkus.rest-client.client-key.scope=Singleton

can now be set globally with:

quarkus.rest-client.scope=Singleton

In this case the scope configuration would be applied to all REST client
instances unless it is overridden by client-specific configuration.

Following properties were added to the global scope:

scope
providers
follow-redirects
query-param-style
hostname-verifier
connection-ttl
connection-pool-size
max-redirects
headers

trust-store
trust-store-password
trust-store-type

key-store
key-store-password
key-store-type

This commit adds global properties for most of configuration options
that can be set to individual REST client instances. E.g. the scope
property, that previously could only be set for specific client with:

`quarkus.rest-client.client-key.scope=Singleton`

can now be set globally with:

`quarkus.rest-client.scope=Singleton`

In this case the scope configuration would be applied to all REST client
instances unless it is overridden by client-specific configuration.

Following properties were added to the global scope:

scope
providers
follow-redirects
query-param-style
hostname-verifier
connection-ttl
connection-pool-size
max-redirects
headers

trust-store
trust-store-password
trust-store-type

key-store
key-store-password
key-store-type
@TomasHofman
Copy link
Contributor Author

Apart from adding the global properties, this PR also changes the REST client keystore & truststore properties interpretation such that the value "none" means the keystore or truststore is undefined. Previously the value "none" would be interpreted as valid path.

@TomasHofman
Copy link
Contributor Author

Cc @geoand

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, very nice!

@Sgitario would you like to review this?

Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@geoand geoand merged commit 50ebd1f into quarkusio:main Sep 5, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Sep 5, 2022
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More global Rest Client configs
3 participants