Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid mixing the RESTEasy Classic and RESTEasy Reactive REST layers #27750

Merged
merged 1 commit into from Sep 6, 2022
Merged

Avoid mixing the RESTEasy Classic and RESTEasy Reactive REST layers #27750

merged 1 commit into from Sep 6, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Sep 6, 2022

@Sgitario I'm surprised this didn't trigger a build error? I thought we had guards to avoid this kind of mixup.

Sgitario
Sgitario approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just checked it and we are not checking whether RESTEasy Classic and RESTEasy Reactive are both used , but we could certainly do this and throw a proper error message.

@gsmet
Copy link
Member Author

gsmet commented Sep 6, 2022

Hmmmm, that's extremely weird. I'm pretty sure we had checks for that at some point.

@gsmet gsmet merged commit d68486c into quarkusio:main Sep 6, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sgitario Sgitario Sgitario approved these changes

Assignees
No one assigned
Labels
area/resteasy-reactive
Projects
None yet
Milestone
2.13.0.CR1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gsmet @Sgitario