Bump mockito-bom from 4.7.0 to 4.8.0 #27833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [mockito-bom](https://github.com/mockito/mockito) from 4.7.0 to 4.8.0. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v4.7.0...v4.8.0) --- updated-dependencies: - dependency-name: org.mockito:mockito-bom dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
quarkus-bot
bot
added
area/dependencies
|
@FroMage @loicmathieu WDYT about |
gsmet
approved these changes
Sep 9, 2022
gastaldi
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #27819
The bad news is that, clearly,
PanacheMock#mockMethodwas (and still is) a disaster waiting to happen: it relies on Mockito's internals... The only solution I had to make it work exactly the same way as before was to break backwards compatibility. People wanting to stay on Mockito 4.7 will no longer be able to usePanacheMock#mockMethod. And it's still relying on internals, so we could have the same problem again anytime.The good news is that
PanacheMock#mockMethodis not documented as far as I can tell. It's not even tested. So I think we should be able to remove it... Maybe I should open a dedicated PR for that?/cc @gsmet