Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove javax generated classes from mapstruct gradle tests #28072

Merged
merged 1 commit into from Sep 20, 2022
Merged

Remove javax generated classes from mapstruct gradle tests #28072

merged 1 commit into from Sep 20, 2022

Conversation

glefloch
Copy link
Member

This disables CDI capabilities from mapstruct to make sure no jakarta classes are used in the generated code.

close #28005

@glefloch glefloch requested a review from gsmet September 19, 2022 20:53
@quarkus-bot quarkus-bot bot added the area/gradle Gradle label Sep 19, 2022
gsmet
gsmet approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@gsmet gsmet merged commit 71445ca into quarkusio:main Sep 20, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 20, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.4.Final Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/gradle Gradle area/jakarta
Projects
None yet
Milestone
2.13.4.Final
Development

Successfully merging this pull request may close these issues.

Jakarta - EE 10 - Gradle annotation processor test failing
2 participants
@glefloch @gsmet