Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that classes declaring @ServerRequestFilter can contain non-static fields #28079

Merged
merged 2 commits into from Sep 20, 2022
Merged

Ensure that classes declaring @ServerRequestFilter can contain non-static fields #28079

merged 2 commits into from Sep 20, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 20, 2022

Same goes for @ServerResponseFilter.

This is done by making the generated classes @ApplicationScoped, thus ensuring
that their instantiation is done lazily instead of eagerly.

Resolves: #27752

@geoand geoand mentioned this pull request Sep 20, 2022
Closed
@quarkus-bot

This comment has been minimized.

Sign in to view
Sgitario
Sgitario reviewed Sep 20, 2022
View reviewed changes
Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this was only failing in native and that's why you didn't add any tests, right?

...a/org/jboss/resteasy/reactive/server/processor/generation/filters/CustomFilterGenerator.java Outdated Show resolved Hide resolved
@geoand
Copy link
Contributor Author

geoand commented Sep 20, 2022

So, this was only failing in native and that's why you didn't add any tests, right?

Good point, I'll add one

@geoand
Copy link
Contributor Author

geoand commented Sep 20, 2022

PR updated

Sgitario
Sgitario approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now, thanks!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 20, 2022
@sberyozkin
Copy link
Member

Thanks very much @geoand for looking at this enhancement

@geoand
Copy link
Contributor Author

geoand commented Sep 20, 2022

🙏🏼

@quarkus-bot

This comment has been minimized.

Sign in to view
@geoand
Refactor CustomFilterGenerator
4543367
@geoand
Ensure that classes declaring @ServerRequestFilter can contain non-st…
1ca6f09 
…atic fields

This is done by making the generated classes @ApplicationScoped, thus ensuring
that their instantiation is done lazily instead of eagerly.

Resolves: quarkusio#27752
@geoand geoand merged commit 415ba74 into quarkusio:main Sep 20, 2022
@geoand geoand deleted the #27752 branch September 20, 2022 16:12
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 20, 2022
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sgitario Sgitario Sgitario approved these changes

Assignees
No one assigned
Labels
area/resteasy-reactive kind/enhancement New feature or request
Projects
None yet
Milestone
2.14.0.CR1
Development

Successfully merging this pull request may close these issues.

Make it possible to have non-static SecureRandom in RESTEasy Reactive filters
3 participants
@geoand @sberyozkin @Sgitario