Instructions for managing M1 self-hosted runner #28086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holly-cummins
force-pushed
the
m1-instructions
branch
from
190c8bf
to
29827d4
Compare
gsmet
requested changes
Sep 20, 2022
ACTIONS.md
Outdated
| ### Non-root user | ||
|
|
||
| GitHub actions should not run with administrator privileges. | ||
| Make an account for the actions runner. *Grant administrator privileges to the account* (we will remove them later). |
There was a problem hiding this comment.
Given you have a name for the account later, maybe add it there to be consistent?
ACTIONS.md
Outdated
| systemctl reboot | ||
| ``` | ||
|
|
||
| Now remove administrator privileges from the `githubactions` user. |
There was a problem hiding this comment.
Maybe an hint of how it can be done? Or it's obvious for someone familiar with macOS?
Also added capitalisation corrections and improved instructions for user management. Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com>
|
Suggestions implemented - thanks! |
|
Could you squash the commits? Thanks. |
holly-cummins
force-pushed
the
m1-instructions
branch
from
b748402
to
edb7449
Compare
|
The good news is that I actually had squashed the commits. The bad news is I hadn't pushed. So I'm glad you didn't merge! There's a bit of extra commentary about managing users (per your suggestions) on top of what you saw when you last looked. |
gsmet
approved these changes
Sep 20, 2022
gsmet
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @gsmet, I have documented the set up instructions for the Mac M1 self-hosted runner added in #27156.
I also removed some hardcoding from our podman instructions.