Refactor how ORM with Panache generates bridge methods #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dge` to non-rx panache
dmlloyd
reviewed
Jun 13, 2019
...ment/src/main/java/io/quarkus/hibernate/orm/panache/deployment/PanacheJpaEntityEnhancer.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/quarkus/hibernate/orm/panache/deployment/PanacheJpaRepositoryEnhancer.java
Outdated
Show resolved
Hide resolved
evanchooly
approved these changes
Jun 13, 2019
...anache/deployment/src/main/java/io/quarkus/hibernate/orm/panache/deployment/EntityField.java
Show resolved
Hide resolved
...c/main/java/io/quarkus/hibernate/orm/panache/deployment/PanacheFieldAccessMethodVisitor.java
Show resolved
Hide resolved
| generateMethod("deleteAll", "()J", null, Opcodes.LRETURN, null); | ||
| for (MethodInfo method : panacheEntityBaseClassInfo.methods()) { | ||
| AnnotationInstance bridge = method.annotation(JandexUtil.DOTNAME_GENERATE_BRIDGE); | ||
| if (bridge != null) |
There was a problem hiding this comment.
do we require braces? (please say yes)
There was a problem hiding this comment.
I'll say not if the formatter does not, and it does not ;)
|
Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more special cases: all methods annotated with
GenerateBridgewill be plugged in, like I had it in panache-rx.Added the panache-common-deployment module to hold classes common to both jpa/rx implementations that have no place at runtime.