Stop index warn by excluding resource removed by extension from indexing #28214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @geoand I can divide this to 2 PRs if you think it's appropriate. I added this as one PR as changes are tiny. |
This comment has been minimized.
This comment has been minimized.
|
Hi, Thanks for this! Furthermore, I'd like @aloubyansky to verify this |
|
Looks good, thanks! |
michalvavrik
force-pushed
the
feature/exclude-removed-resources-from-indexing
branch
from
18b106f
to
6fd688c
Compare
Excluded resources removed by extension from indexing as according to io.quarkus.maven.ExtensionDescriptorMojo#removedResources should be equivalent of quarkus.class-loading.removed-resources, however later classes are excluded from indexing while former are not.
michalvavrik
force-pushed
the
feature/exclude-removed-resources-from-indexing
branch
from
6fd688c
to
34b21a7
Compare
|
PR is split into 2 commits. Thank you for reviews. |
geoand
approved these changes
Sep 27, 2022
aloubyansky
approved these changes
Sep 27, 2022
geoand
added
the
triage/waiting-for-ci
|
✖ This workflow run has failed but no jobs reported an error. Something weird happened, please check the workflow run page carefully: it might be an issue with the workflow configuration itself. |
quarkus-bot
bot
added
kind/bugfix
and removed
triage/waiting-for-ci
michalvavrik
deleted the
feature/exclude-removed-resources-from-indexing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #27907
Excludes resources removed by extension from indexing as according to
io.quarkus.maven.ExtensionDescriptorMojo#removedResourcesshould be equivalent ofquarkus.class-loading.removed-resources, however later classes are excluded from indexing while former are not. Fix is used to excludeorg.keycloak.admin.client.JacksonProviderthat extendsorg.jboss.resteasy.plugins.providers.jackson.ResteasyJackson2Providerfrom indexing. The file is never used as we setio.quarkus.keycloak.admin.client.reactive.runtime.ResteasyReactiveKeycloakAdminClientRecorder#setClientProviderand it produces incorrect warning (see linked issue).