New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade quarkus-arquillian to use JUnit 5 #28248
Conversation
If you decide to proceed with the changes in this pull request, it should be noted in the migration guide as a breaking change. |
@Sgitario if /we/ decide, you're part of the team. |
@mkouba did you remember why you targeted JUnit 4? Was it because of a lack of support of JUnit 5 in Arquillian or did we need it for some TCKs? |
This comment has been minimized.
This comment has been minimized.
d973670
to
6cc1820
Compare
It seems that some TCKs need the support of JUnit 5. So, I've just updated the pull request to support both JUnit 5 and JUnit 4. |
This comment has been minimized.
This comment has been minimized.
It was the lack of support in Arquillian. And I believe that the TCKs that used JUnit at that time were using JUnit4 APIs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I think we're not far from being able to merge this PR.
I added a few comments. As for testing JUnit 4, it's either simple and we do it or it's not and we can live without it. Don't spend time on that.
test-framework/arquillian/src/test/java/io/quarkus/arquillian/test/SimpleTest.java
Show resolved
Hide resolved
test-framework/arquillian/src/main/java/io/quarkus/arquillian/QuarkusJunitCallbacks.java
Outdated
Show resolved
Hide resolved
6cc1820
to
d8d9cc7
Compare
PR updated with the resolved change requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Nice having this ready for future MP versions.
@radcortez FYI regarding MP TCKs. |
Fix #27812