Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade quarkus-arquillian to use JUnit 5 #28248

Merged
merged 1 commit into from Oct 6, 2022

Conversation

Sgitario
Copy link
Contributor

Fix #27812

@Sgitario
Copy link
Contributor Author

If you decide to proceed with the changes in this pull request, it should be noted in the migration guide as a breaking change.

@gsmet
Copy link
Member

gsmet commented Sep 28, 2022

@Sgitario if /we/ decide, you're part of the team.

@gsmet
Copy link
Member

gsmet commented Sep 28, 2022

@mkouba did you remember why you targeted JUnit 4? Was it because of a lack of support of JUnit 5 in Arquillian or did we need it for some TCKs?

@quarkus-bot

This comment has been minimized.

@Sgitario
Copy link
Contributor Author

@mkouba did you remember why you targeted JUnit 4? Was it because of a lack of support of JUnit 5 in Arquillian or did we need it for some TCKs?

It seems that some TCKs need the support of JUnit 5. So, I've just updated the pull request to support both JUnit 5 and JUnit 4.

@quarkus-bot

This comment has been minimized.

@mkouba
Copy link
Contributor

mkouba commented Sep 29, 2022

@mkouba did you remember why you targeted JUnit 4? Was it because of a lack of support of JUnit 5 in Arquillian or did we need it for some TCKs?

It was the lack of support in Arquillian. And I believe that the TCKs that used JUnit at that time were using JUnit4 APIs.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think we're not far from being able to merge this PR.

I added a few comments. As for testing JUnit 4, it's either simple and we do it or it's not and we can live without it. Don't spend time on that.

@Sgitario
Copy link
Contributor Author

Sgitario commented Oct 4, 2022

PR updated with the resolved change requests.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Nice having this ready for future MP versions.

@gsmet
Copy link
Member

gsmet commented Oct 4, 2022

@radcortez FYI regarding MP TCKs.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 4, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 4, 2022

Failing Jobs - Building d8d9cc7

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@gsmet gsmet merged commit cdd2295 into quarkusio:main Oct 6, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 6, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 6, 2022
@Sgitario Sgitario deleted the arquillian_junit5 branch October 7, 2022 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade quarkus-arquillian to use JUnit 5
3 participants