Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes: Allow disabling the annotation "app.kubernetes.io/name" #28315

Merged
merged 1 commit into from Oct 4, 2022

Conversation

Sgitario
Copy link
Contributor

Related to #28297

@quarkus-bot

This comment has been minimized.

Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the vcs part as this is something that is meant to be covered in other pull request. More specifically #27027 deals with it in a more generic way (by adding a flag for all fields that affect idempotency). While the PR is not merged at the time of review, I prefer that approach over this.

So, let's remove the vcs part and keep the remaining which is great btw.

@Sgitario Sgitario force-pushed the feat_kubernetes_annotations_disable branch from c7ec82e to eb7247a Compare October 4, 2022 12:32
@Sgitario Sgitario requested a review from iocanel October 4, 2022 12:33
@Sgitario
Copy link
Contributor Author

Sgitario commented Oct 4, 2022

I would remove the vcs part as this is something that is meant to be covered in other pull request. More specifically #27027 deals with it in a more generic way (by adding a flag for all fields that affect idempotency). While the PR is not merged at the time of review, I prefer that approach over this.

So, let's remove the vcs part and keep the remaining which is great btw.

PR updated! Thanks for the review.

@Sgitario Sgitario changed the title Kubernetes: Allow disabling VCS annotations and app.kubernetes.io/name Kubernetes: Allow disabling the annotation "app.kubernetes.io/name" Oct 4, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 4, 2022

Failing Jobs - Building eb7247a

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsmet gsmet merged commit acb33b3 into quarkusio:main Oct 4, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 4, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.1.Final Oct 4, 2022
@Sgitario Sgitario deleted the feat_kubernetes_annotations_disable branch October 5, 2022 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants