Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Vert.x 4.3.4 #28323

Merged
merged 1 commit into from Oct 1, 2022
Merged

Update to Vert.x 4.3.4 #28323

merged 1 commit into from Oct 1, 2022

Conversation

cescoffier
Copy link
Member

@cescoffier cescoffier commented Sep 30, 2022 •
edited

  • Bump dependency
  • Update substitutions
  • Add missing methods

Fix #27918.

@cescoffier
Update to Vert.x 4.3.4
6b795e7 
* Bump dependency
* Update substitutions
* Add missing methods
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/vertx labels Sep 30, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 30, 2022

Failing Jobs - Building 6b795e7

Status Name Step Failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18
✔️ Maven Tests - JDK 11
⌛ Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/reactive-messaging-hibernate-orm

📦 integration-tests/reactive-messaging-hibernate-orm

✖ io.quarkus.it.kafka.KafkaConnectorTest.testFruits line 50 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <2> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

@cescoffier cescoffier requested a review from geoand October 1, 2022 15:03
geoand
geoand approved these changes Oct 1, 2022
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I'll also follow up by removing my REST Client multipart "fix"

@gsmet gsmet merged commit 1cdc965 into quarkusio:main Oct 1, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 1, 2022
@cescoffier cescoffier deleted the update-to-vertx-4.3.4 branch October 2, 2022 07:01
@cescoffier cescoffier mentioned this pull request Oct 3, 2022
Closed
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.1.Final Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/vertx kind/bugfix
Projects
None yet
Milestone
2.13.1.Final
Development

Successfully merging this pull request may close these issues.

mail extension - socket was closed unexpected when shutting down the app
3 participants
@cescoffier @gsmet @geoand