Run the method scheduled with the Quartz scheduler on a duplicated context #28348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machi1990
approved these changes
Oct 3, 2022
|
lgtm, thank @cescoffier for the followup. let's get a review from @mkouba as well. |
This comment has been minimized.
This comment has been minimized.
|
I wonder if we should have a config switch ( |
cescoffier
force-pushed
the
run-scheduled-methods-with-quartz-on-dc
branch
from
db34336
to
c69cba6
Compare
|
@mkouba implemented and updated. |
This comment has been minimized.
This comment has been minimized.
mkouba
reviewed
Oct 6, 2022
extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzSchedulerImpl.java
Outdated
Show resolved
Hide resolved
…ntext. This is the follow-up of quarkusio#28255. When running the scheduled method, the lack of duplicated context can lead to contextual data loss (loss only, no leak). This commit makes sure that the method runs with a duplicated context. However, this is a breaking change for users expecting the method to run on a Quartz thread.
cescoffier
force-pushed
the
run-scheduled-methods-with-quartz-on-dc
branch
from
c69cba6
to
9452ab3
Compare
mkouba
approved these changes
Oct 6, 2022
mkouba
added
the
triage/waiting-for-ci
|
@cescoffier Pls add a note to the Migration-Guide-2.14. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the follow-up of #28255.
When running the scheduled method, the lack of duplicated context can lead to contextual data loss (loss only, no leak).
This commit makes sure that the method runs with a duplicated context.
However, this is a breaking change for users expecting the method to run on a Quartz thread.