Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OIDC DevUI to accept hybrid application types #28408

Merged
merged 1 commit into from Oct 6, 2022

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented Oct 5, 2022

Minor update to provider.html to treat hybrid application types the same way as service types - since hybrid types will either do the bearer token verification (with Dev UI sending them) or will start a code flow if the token is not available.

The main reason, apart from supporting the hybrid applications directly, is to help testing web-app applications - the docs recommend to switch such applications to service in devmode for DevUI be more useful - but hybrid is a better option in such cases, as a direct browser to Quarkus calls will be still handled in the web-app mode, while hybrid will also let OIDC Dev UI treat it the same way it does service (with Swagger UI support, etc)

Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Quarkus Documentation automation moved this from To do to Reviewer approved Oct 5, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 6, 2022

Failing Jobs - Building c540c11

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@sberyozkin
Copy link
Member Author

Thanks @phillip-kruger

@sberyozkin sberyozkin merged commit 4dfa703 into quarkusio:main Oct 6, 2022
Quarkus Documentation automation moved this from Reviewer approved to Done Oct 6, 2022
@sberyozkin sberyozkin deleted the keycloak-dev-services-hybrid branch October 6, 2022 08:42
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 6, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.2.Final Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants