Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dekorate from 3.0.0 to 3.0.2 #28438

Merged
merged 1 commit into from Oct 20, 2022
Merged

Bump dekorate from 3.0.0 to 3.0.2 #28438

merged 1 commit into from Oct 20, 2022

Conversation

Sgitario
Copy link
Contributor

@Sgitario Sgitario commented Oct 6, 2022

Fix #26587
Fix #28297
Fix #28078

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/kubernetes labels Oct 6, 2022
@quarkus-bot

This comment has been minimized.

Sign in to view
@Sgitario Sgitario mentioned this pull request Oct 7, 2022
Closed
@Sgitario Sgitario requested a review from iocanel October 7, 2022 06:24
@Sgitario
Copy link
Contributor Author

Sgitario commented Oct 7, 2022

The test failures are unrelated to these changes. Would you mind to take a look @iocanel ?

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 7, 2022

Failing Jobs - Building 61b5978

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

iocanel
iocanel approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me.

...es/kind/deployment/src/main/resources/META-INF/services/io.dekorate.ManifestGeneratorFactory
@@ -0,0 +1 @@
io.dekorate.kind.manifest.KindManifestGeneratorFactory
Copy link
Contributor

@iocanel iocanel Oct 10, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this needs to be addressed in dekorate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should we merge this one or is there some additional work planned we want to push to this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the PR is ready to be merged.
Take into account that this PR depends on Fabric8 Kubernetes Client 6.x which is only in main.

@gsmet gsmet merged commit 86a8aa9 into quarkusio:main Oct 20, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 20, 2022
@pjgg pjgg mentioned this pull request Oct 20, 2022
Closed
@Sgitario Sgitario deleted the bump_dekorate branch October 21, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@iocanel iocanel iocanel approved these changes

Assignees

@iocanel iocanel

Labels
area/dependencies Pull requests that update a dependency file area/kubernetes kind/bugfix
Projects
None yet
Milestone
2.14.0.CR1
3 participants
@Sgitario @iocanel @gsmet