Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro versions updates #2857

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Micro versions updates #2857

merged 1 commit into from
Jun 19, 2019

Conversation

rsvoboda
Copy link
Member

Micro versions updates

Local jvm run passed, let's see how native mode works out.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the Netty upgrade, it looks good. But... I would really prefer if we merge this AFTER Wednesday release.

bom/pom.xml Outdated Show resolved Hide resolved
@gsmet gsmet added this to the 0.18.0 milestone Jun 17, 2019
@rsvoboda
Copy link
Member Author

PR updated, netty version bump removed

@gsmet
Copy link
Member

gsmet commented Jun 17, 2019

@geoand can you have a look, it updates AP4K?
@cescoffier can you have a look, it updates a few reactive components?

@geoand
Copy link
Contributor

geoand commented Jun 17, 2019

@gsmet ap4k works, I just tried it

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Vert.x and Axle, this is covered by #2872.

bom/pom.xml Show resolved Hide resolved
bom/pom.xml Show resolved Hide resolved
@rsvoboda
Copy link
Member Author

rsvoboda commented Jun 18, 2019

OK, I will wait for #2872 and rebase+update this PR after 2872 is merged

@gsmet gsmet added the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Jun 18, 2019
@gsmet
Copy link
Member

gsmet commented Jun 18, 2019

@rsvoboda I let you rebase it. Thanks!

@rsvoboda rsvoboda removed the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Jun 19, 2019
@rsvoboda
Copy link
Member Author

Rebased

@FroMage FroMage added kind/enhancement New feature or request triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jun 19, 2019
@gsmet gsmet dismissed cescoffier’s stale review June 19, 2019 11:29

Comments addressed.

@gsmet gsmet merged commit a5c28c3 into quarkusio:master Jun 19, 2019
@rsvoboda rsvoboda deleted the micro.versions.updates.2019-06-17 branch August 5, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants