Generate the attributes.adoc file during the build #28581
Conversation
|
Hmm. Can we flip this around a little so local previews still work? All of the docs reference |
|
What do you call local preview? The Now we could reapply the But really, be more precise about what you expect. |
|
Raw edit in the IDE. This is the easiest way to edit docs with feedback, so I've been trying to make sure using preview works. We could update all of the files to reference |
Currently, we maintain a copy of the attributes.adoc in the website and we always get it wrong when we add a new attribute. This way, attributes.adoc will come directly from the release and will be complete. Attributes that can be overridden has been moved to attributes-local.adoc. attributes-local.adoc won't be overwritten when syncing.
|
@ebullient would this new version work for you? For local preview, attributes will contain the Maven properties but I think it's acceptable as it improves our workflow a lot. And I'm not sure they were properly replaced before anyway. |
YES! 🎉
Correct, the property values weren't replaced before either. So that's fine. |
Currently, we maintain a copy of the attributes.adoc in the website and we always get it wrong when we add a new attribute.
This way, attributes.adoc will come directly from the release and will be complete.
Attributes that can be overridden have been moved to attributes-local.adoc. attributes-local.adoc won't be overwritten when syncing.
@ebullient this should solve the problem of having to (badly) sync the attributes between the main repository and the website. The
attributes.adocfile will now be generated and synced and I created a newattributes-local.adocfile that is not synced and can be overridden (typically for paths that are specific to the environment).