Use vale linting for AsciiDoc files #28584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
gsmet
reviewed
Oct 14, 2022
docs/src/main/java/io/quarkus/docs/generation/YamlMetadataGenerator.java
Outdated
Show resolved
Hide resolved
|
@ebullient - The rules need to be updated with the latest on the QDOCS sandbox that I added this week. For example, Quarkiverse and Gradle. I also added fixes for 'searchability' and 'findability' false positives this morning. Thanks :-) |
ebullient
force-pushed
the
docs-vale
branch
2 times, most recently
from
9aa6043
to
2caf8e2
Compare
This comment has been minimized.
This comment has been minimized.
|
@ebullient - Thanks for updating the Quarkus vale ruleset. I can now see the latest terms that were added last week, for example, "[fF]inability" and "[sS]earchability"... LGTM. |
michelle-purcell
approved these changes
Oct 17, 2022
|
Rebased. |
gsmet
approved these changes
Oct 18, 2022
gsmet
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #28481