Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling Jackson ObjectMapper WRITE_DURATIONS_AS_TIMESTAMPS #28617

Merged
merged 1 commit into from Oct 17, 2022
Merged

Allow disabling Jackson ObjectMapper WRITE_DURATIONS_AS_TIMESTAMPS #28617

merged 1 commit into from Oct 17, 2022

Conversation

davidfrickert
Copy link
Contributor

Fixes #28605

@quarkus-bot quarkus-bot bot added the area/jackson Issues related to Jackson (JSON library) label Oct 15, 2022
@davidfrickert
Copy link
Contributor Author

I opted to set the default config the same that is provided by Jackson - which is to serialize Durations as Timestamps - in order to not break existing Quarkus applications that are using the default value.

@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@davidfrickert
Copy link
Contributor Author

It seems I missed the Intellij IDEA configuration part of the import order file. Going to install it and fix the import order of the tests.

@gsmet
Copy link
Member

gsmet commented Oct 15, 2022

Just run mvn process-sources.

@gsmet
Copy link
Member

gsmet commented Oct 15, 2022

Also please squash all the commits when you're done.

@davidfrickert
Copy link
Contributor Author

Thanks for the tip @gsmet. I ended up installing the plugin and fixing the imports with it. Also did a force push with a single commit. Just ran mvn process-sources and it didn't perform any changes so it should be good now.

@quarkus-bot

This comment has been minimized.

Sign in to view
@geoand geoand added triage/backport-2.13 triage/waiting-for-ci Ready to merge when CI successfully finishes labels Oct 17, 2022
@gsmet gsmet merged commit 5c60613 into quarkusio:main Oct 17, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 17, 2022
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Oct 17, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.3.Final Oct 17, 2022
@davidfrickert davidfrickert deleted the #28605 branch October 17, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/jackson Issues related to Jackson (JSON library) kind/enhancement New feature or request
Projects
None yet
Milestone
2.13.3.Final
Development

Successfully merging this pull request may close these issues.

Allow disabling Jackson ObjectMapper WRITE_DURATIONS_AS_TIMESTAMPS
4 participants
@davidfrickert @gsmet @gastaldi @geoand