Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve gradle user home misconfiguration #28624

Conversation

aaronrebak
Copy link
Contributor

Resolves issue: #20928

Traditionally happens against a CI pipeline with a custom gradle user home.

The issue occurs when extensions such as quarkus-jacoco attempt to load an ApplicationModel and the project being used:

  • Contains a custom gradle user home that is not ~./gradle
  • The custom gradle user home contains custom gradle.properties (traditionally something like repoUsername and repoPassword) in order to resolve dependencies from a private repository.

As a result of the custom gradle.properties file missed, the user is presented with errors related to missing gradle properties or not being able to resolve dependencies.

…ing dynamic lookup for gradle user home when loading ApplicationModel
@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Oct 16, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 16, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should count at least 2 words to describe the change properly
  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@aaronrebak aaronrebak changed the title bugfix/resolve-gradlemodelfactory-gradleuserhome-misconfiguration Resolve gradle user home misconfiguration Oct 16, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 17, 2022

Failing Jobs - Building c4757f5

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 17 MacOS M1
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: test-framework/common 
! Skipped: devtools/cli extensions/agroal/deployment extensions/agroal/runtime and 607 more

📦 test-framework/common

io.quarkus.test.common.TestResourceManagerInjectorTest.testTestInjector - More details - Source on GitHub

java.util.concurrent.CompletionException: org.opentest4j.AssertionFailedError: The SecondParallelQuarkusTestResource did not run yet! ==> expected: <true> but was: <false>
	at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:314)
	at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:319)

@aloubyansky aloubyansky merged commit 4c76723 into quarkusio:main Oct 17, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 17, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.3.Final Oct 17, 2022
@aaronrebak aaronrebak deleted the bugfix/resolve-gradlemodelfactory-gradleuserhome-misconfiguration branch October 17, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants