New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the number of classes that are loaded by our AppCDS support #28638
Conversation
This actually does make a (small) but much more notireable dent in startup time vs our current AppCDS support. |
Feels related to #28290 or at least could be useful appcds gets recorded at similar time a resume/suspend snapshot happens. |
Yeah, it's fairly similar, but this is very very targeted |
@stuartwdouglas can you think of any reason not to make this enhancement? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the more classes that are loaded the better (assuming these are going to be loaded anyway).
The way this is done is by picking a much later point in the startup process that is safe for the application to reach. This point is basically when Arc has created all its beans as frameworks commence their work after this point.
Failing Jobs - Building b850d5b
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/vertx/deployment
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 340 more 📦 extensions/vertx/deployment✖
|
Follow up of quarkusio#28638 as I had managed to forget to commit this part...
Follow up of quarkusio#28638 as I had managed to forget to commit this part...
The way this is done is by picking a much later point in the startup process that is safe for the application to reach. This point is basically when Arc has created all its beans as frameworks commence their work after this point.