Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add property to set the global default Quartz misfire instruction #28716

Merged
merged 1 commit into from Nov 2, 2022
Merged

Add property to set the global default Quartz misfire instruction #28716

merged 1 commit into from Nov 2, 2022

Conversation

mun711
Copy link
Contributor

@mun711 mun711 commented Oct 20, 2022

No description provided.

@mun711 mun711 mentioned this pull request Oct 20, 2022
Closed
@gsmet gsmet force-pushed the feature/global-quartz-misfire-policy branch from 373f2b8 to e57195b Compare October 20, 2022 13:08
@gsmet
Copy link
Member

gsmet commented Oct 20, 2022

I rebased to avoid the merge commit.

Let's see what CI has to say.

@gsmet
Copy link
Member

gsmet commented Oct 20, 2022

And thanks btw :).

@mun711 mun711 force-pushed the feature/global-quartz-misfire-policy branch 2 times, most recently from 87596d1 to a798e15 Compare October 25, 2022 17:57
@quarkus-bot quarkus-bot bot added area/core area/documentation area/hibernate-search Hibernate Search / Elasticsearch area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/jakarta area/kubernetes area/panache labels Oct 25, 2022
@quarkus-bot quarkus-bot bot added this to To do in Quarkus Documentation Oct 25, 2022
@mun711 mun711 force-pushed the feature/global-quartz-misfire-policy branch from a798e15 to ff80d5f Compare October 25, 2022 17:59
machi1990
machi1990 requested changes Oct 25, 2022
View reviewed changes
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one minor comment, otherwise the change looks good to me.

Thanks a lot @mun711 for the work.

Quarkus Documentation automation moved this from To do to Review pending Oct 25, 2022
gsmet
gsmet previously requested changes Oct 25, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also need a rebase to avoid the merge commit.

@mun711 mun711 force-pushed the feature/global-quartz-misfire-policy branch from 4c4e6fc to 119a495 Compare October 27, 2022 12:46
@machi1990
Copy link
Member

This will also need a rebase to avoid the merge commit.

@mun711 can you address this comment so that we can merge the PR? Thanks

@mun711 mun711 force-pushed the feature/global-quartz-misfire-policy branch from ddbce48 to 2ad3f5f Compare October 27, 2022 13:22
@machi1990 machi1990 requested a review from gsmet October 27, 2022 13:24
@mun711 mun711 force-pushed the feature/global-quartz-misfire-policy branch from 2ad3f5f to 685728c Compare October 27, 2022 13:26
@mun711
Copy link
Contributor Author

mun711 commented Oct 27, 2022

This will also need a rebase to avoid the merge commit.

done

@mun711 mun711 force-pushed the feature/global-quartz-misfire-policy branch 5 times, most recently from 873b675 to 3567dd3 Compare October 28, 2022 16:34
@mun711 mun711 force-pushed the feature/global-quartz-misfire-policy branch from 3567dd3 to c8cf2ff Compare October 29, 2022 17:44
@mun711
Copy link
Contributor Author

mun711 commented Oct 29, 2022

@machi1990 @gsmet - I rebased as mentioned but the sanity check seems to wait for an approve to start - could you check this please

@famod
Copy link
Member

famod commented Oct 29, 2022

FTR, I approved the workflow run.

@geoand geoand dismissed gsmet’s stale review November 1, 2022 16:48

issue addressed

Quarkus Documentation automation moved this from Review pending to Reviewer approved Nov 1, 2022
@geoand
Copy link
Contributor

geoand commented Nov 1, 2022

@mkouba want to take a look at this as well?

mkouba
mkouba approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mkouba mkouba merged commit fdb63cd into quarkusio:main Nov 2, 2022
Quarkus Documentation automation moved this from Reviewer approved to Done Nov 2, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba approved these changes

@machi1990 machi1990 machi1990 approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
area/core area/documentation area/hibernate-search Hibernate Search / Elasticsearch area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/jakarta area/kubernetes area/panache area/scheduler
Projects
Quarkus Documentation
Done
Milestone
2.15.0.CR1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mun711 @gsmet @machi1990 @famod @geoand @mkouba