Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the ordering of Maven repos in tests matches the ordering of the repos in Mojos #28759

Merged

Conversation

aloubyansky
Copy link
Member

No description provided.

@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Oct 21, 2022
@aloubyansky aloubyansky force-pushed the keep-activated-repos-from-settings branch from 61dbb17 to 9bf92f7 Compare October 21, 2022 19:53
@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 22, 2022

Failing Jobs - Building 9bf92f7

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Failures Logs Raw logs
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 MacOS M1 #

- Failing: integration-tests/mongodb-devservices 

📦 integration-tests/mongodb-devservices

io.quarkus.it.mongodb.BookResourceTest.health line 45 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:283)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:309)

io.quarkus.it.mongodb.BookResourceTest.testReactiveClients line 39 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:283)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:309)

io.quarkus.it.mongodb.BookResourceTest.testBlockingClient line 34 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:283)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:309)

io.quarkus.it.mongodb.BookResourceWithParameterInjectionTest.testInjectedClient line 31 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:283)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:309)

io.quarkus.it.mongodb.OtherProfileBookResourceTest.testBlockingClient line 14 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:283)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:309)

@aloubyansky
Copy link
Member Author

I've noticed these tests failing on MacOS in other PRs too.

@geoand
Copy link
Contributor

geoand commented Oct 24, 2022

I've noticed these tests failing on MacOS in other PRs too.

Yup, maybe we need to restart the runners @holly-cummins?

@geoand
Copy link
Contributor

geoand commented Oct 24, 2022

Does this fix a known issue?

@aloubyansky
Copy link
Member Author

aloubyansky commented Oct 24, 2022

There is no existing issue on github it would resolve (afaik). There are two issues I wanted to fix:

  1. The order of remote Maven repositories from active profiles configured in settings.xml in quarkus:generate-code[-test] and quarkus:build is different from the one we end up with resolving dependencies in test phases.
  2. Outside Quarkus bootstrap, once the "Maven context" with its remote repos was initialized using the default settings, re-initializing the "Maven context" using custom settings based on the default user settings may loose some repos. I found it implementing some tools/features for the Quarkus platform.

@aloubyansky aloubyansky merged commit 1b4f255 into quarkusio:main Oct 24, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 24, 2022
@holly-cummins
Copy link
Contributor

I've noticed these tests failing on MacOS in other PRs too.

Yup, maybe we need to restart the runners @holly-cummins?

We've got a zulip thread for this issue, but I'll convert it to an issue since I think this is going to be a slow burner: #28779.

I've restarted the runners, but sadly it didn't help. I also can't reproduce locally. My "best" analysis, from looking at the line of code which is failing, is that build pixies come in, remove the docker binary from the machine while the mongo tests run, and then sneak back and reinstate the docker binary. (Somewhere, Occam's razor has its razor-head in its razor-hands.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants